New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pausing/un alerts now updates new_state_date #10942

Merged
merged 2 commits into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@xlson
Contributor

xlson commented Feb 16, 2018

No description provided.

alerting: pausing alerts modifies updated.
When pausing an alert the updated field is
modified to the current time.

Closes #10191

@xlson xlson requested a review from bergquist Feb 16, 2018

@bergquist

Looks good. Do you want to merge this into 5.0 or after we branch of 5.0?

@xlson

This comment has been minimized.

Show comment
Hide comment
@xlson

xlson Feb 16, 2018

Contributor

@bergquist doesn't really matter to me. Perhaps we'd better just wait. Doesn't feel like its super important.

Contributor

xlson commented Feb 16, 2018

@bergquist doesn't really matter to me. Perhaps we'd better just wait. Doesn't feel like its super important.

@xlson xlson added this to the 5.1 milestone Feb 16, 2018

@grafana grafana deleted a comment from codecov-io Feb 16, 2018

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Feb 19, 2018

Member

Since paused is a state, is this not correct? Is there an issue describing the problem with updating new_state_date?

Member

torkelo commented Feb 19, 2018

Since paused is a state, is this not correct? Is there an issue describing the problem with updating new_state_date?

@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Feb 19, 2018

Contributor

@torkelo not sure I understand. The problem was that new_state_date wasn't updated.
#10191 kinda weak issue.

It was raised by a user on IRC who thought it was weird that nwe_date_date wasn't updated when an alert was paused/unpaused.

Contributor

bergquist commented Feb 19, 2018

@torkelo not sure I understand. The problem was that new_state_date wasn't updated.
#10191 kinda weak issue.

It was raised by a user on IRC who thought it was weird that nwe_date_date wasn't updated when an alert was paused/unpaused.

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Feb 19, 2018

Member

Ah, sorry, read the PR title wrong :)

Member

torkelo commented Feb 19, 2018

Ah, sorry, read the PR title wrong :)

@xlson xlson changed the title from Pausing/un alerts updates new_state_date to Pausing/un now alerts updates new_state_date Feb 20, 2018

@xlson xlson changed the title from Pausing/un now alerts updates new_state_date to Pausing/un alerts now updates new_state_date Feb 20, 2018

@bergquist bergquist merged commit 3f6e525 into master Mar 7, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@bergquist bergquist deleted the pausing_alerts_updates_timestamp branch Mar 7, 2018

bergquist added a commit that referenced this pull request Mar 7, 2018

bergquist added a commit that referenced this pull request Mar 8, 2018

Merge branch 'master' of github.com:grafana/grafana
* 'master' of github.com:grafana/grafana: (24 commits)
  docs: update latest to 5.0.1
  push 5.0.1 to package cloud
  changelog: adds release date for 5.0.1
  bump master build to 5.1.0-pre1
  move quota to dedicated service
  rename Context to ReqContext
  changelog: note about closing #11145 and #11127
  docs: adds note about closing #10632
  removes commented code
  removes unused variables
  upgrade to go 1.10
  alerting: fixes validation error when saving alerts in dash
  add csv templating format
  docs: note about closing #11046
  docs: adds note about #10942
  Documentation: path "~/go" to "$GOPATH"
  Update ROADMAP.md
  move Context and session out of middleware
  only use jwt token if it contains an email address
  hide row actions for viewers
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment