New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 in Auth proxy white list #11330

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
4 participants
@corny
Contributor

corny commented Mar 21, 2018

No description provided.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Mar 21, 2018

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Mar 21, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 21, 2018

Codecov Report

Merging #11330 into master will decrease coverage by 0.39%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##           master   #11330     +/-   ##
=========================================
- Coverage    51.8%   51.41%   -0.4%     
=========================================
  Files         359      354      -5     
  Lines       26019    25613    -406     
  Branches     1556     1494     -62     
=========================================
- Hits        13480    13169    -311     
+ Misses      11794    11707     -87     
+ Partials      745      737      -8

codecov-io commented Mar 21, 2018

Codecov Report

Merging #11330 into master will decrease coverage by 0.39%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##           master   #11330     +/-   ##
=========================================
- Coverage    51.8%   51.41%   -0.4%     
=========================================
  Files         359      354      -5     
  Lines       26019    25613    -406     
  Branches     1556     1494     -62     
=========================================
- Hits        13480    13169    -311     
+ Misses      11794    11707     -87     
+ Partials      745      737      -8
@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Mar 23, 2018

Contributor

needs rebasing due to golint PR.

Contributor

bergquist commented Mar 23, 2018

needs rebasing due to golint PR.

@corny

This comment has been minimized.

Show comment
Hide comment
@corny

corny Mar 23, 2018

Contributor

Done

Contributor

corny commented Mar 23, 2018

Done

Use net.SplitHostPort to support IPv6
- Add some tests
- Make error message more helpful

@bergquist bergquist added this to the 5.1 milestone Mar 28, 2018

@bergquist bergquist changed the title from Use net.SplitHostPort to support IPv6 to Support IPv6 in Auth proxy Mar 28, 2018

@bergquist bergquist changed the title from Support IPv6 in Auth proxy to Support IPv6 in Auth proxy white list Mar 28, 2018

@bergquist bergquist merged commit f009443 into grafana:master Mar 28, 2018

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-backend Your tests passed on CircleCI!
Details
ci/circleci: test-frontend Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@corny

This comment has been minimized.

Show comment
Hide comment
@corny

corny Mar 28, 2018

Contributor

Thanks a lot!

Contributor

corny commented Mar 28, 2018

Thanks a lot!

@corny corny deleted the digineo:auth-ipv6 branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment