Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Migrating to baron scrollbar WIP #11456
@@ Coverage Diff @@ ## master #11456 +/- ## ========================================== + Coverage 51.9% 51.9% +<.01% ========================================== Files 359 359 Lines 26068 26069 +1 Branches 1571 1571 ========================================== + Hits 13530 13531 +1 Misses 11796 11796 Partials 742 742
The menu seems to mostly work and scroll position seems fine on Firefox and iOS.
I found a couple of things to fix:
First general concern/question. Is it only my that have problems in Chrome that I can't scroll sometimes, but clicking on some area (giving element focus I suppose) allow me to scroll again. This is really irritating. Maybe my laptop's scroll having issues?
Second general concern: Seems like my homepage dashboard no longer can render starred/recent dashboards and installed apps panels. Possibly no height?
Confirmed that this makes #11185 almost completely solved, at least when using an extension called FireShot in Chrome which basically scrolling the page down. Think this is how most of these extensions worls. Partially because there's still an issue when the sidemenu are visible (see first screenshot), but works very good when in kiosk mode (see second screenshot). Maybe not an issue with sidemenu, it's of course because the top header are fixed.