11893 oauth auto login #12029
11893 oauth auto login #12029
Conversation
|
The build seems to have failed because CircleCI has problems accessing npm (see status page). |
|
Rebase onto master to get ride of the codespell errors. circle ci seem to have problems with npm right now. |
|
I rebased the code on master. CircleCI seems to be fine again, too. |
| $location.path('/redirect'); | ||
| window.location.href = url; | ||
| }; | ||
| if ($scope.oauth.google) { |
There was a problem hiding this comment.
Not sure the redirect should have handled in the frontend. Seems easier to redirect the user in the backend. Any specific reason for doing it in the frontend?
There was a problem hiding this comment.
You are absolutely right, redirecting in the backend is cleaner. I will update the PR.
There was a problem hiding this comment.
The PR is ready for review.
|
Do you want me to change anything else? |
|
Sorry! No maintainer had time to review this. We are quite a bit behind but we will get to this. It's a good feature, we just want to review the implementation before merging it. Please be patient :) |
|
Great! I rebased onto master. |
|
I rebased onto master again to include the new changes. |
Redirect in backend
|
Thank you for contributing! |
See issue #11893 for the relevant proposal.
Changes: