Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: adds curl back into the docker image for utility. #13794

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@xlson
Copy link
Contributor

commented Oct 23, 2018

No description provided.

@xlson xlson added this to the 5.3.2 milestone Oct 23, 2018

@xlson xlson self-assigned this Oct 23, 2018

@marefr

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

DId we have curl in old docker image (old repo)? Can't find any history of that we have had curl... Have nothing against adding it, just trying to understand why we need it.

@marefr

marefr approved these changes Oct 23, 2018

@xlson xlson merged commit 4cc89f1 into master Oct 23, 2018

9 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: codespell Your tests passed on CircleCI!
Details
ci/circleci: gometalinter Your tests passed on CircleCI!
Details
ci/circleci: grafana-docker-pr Your tests passed on CircleCI!
Details
ci/circleci: mysql-integration-test Your tests passed on CircleCI!
Details
ci/circleci: postgres-integration-test Your tests passed on CircleCI!
Details
ci/circleci: test-backend Your tests passed on CircleCI!
Details
ci/circleci: test-frontend Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@xlson xlson deleted the dockerimage-curl branch Oct 23, 2018

xlson added a commit that referenced this pull request Oct 23, 2018

@adrianmester

This comment has been minimized.

Copy link

commented Oct 25, 2018

DId we have curl in old docker image (old repo)? Can't find any history of that we have had curl... Have nothing against adding it, just trying to understand why we need it.

It was in the grafana-docker repo

https://github.com/grafana/grafana-docker/blob/master/Dockerfile#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.