Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to handle enable/disable requirement of email in oauth. #16391

Closed
wants to merge 2 commits into from

Conversation

pwcorbett
Copy link

Add parameter to enable OAuth without requiring an email.

Currently login fails if your OAuth user does not have an email or the OAuth provider does not support the apiUrl + "/emails" endpoint.

The default is for an email to be required email_required = true

Closes #13549

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

@mzaret
Copy link

mzaret commented Apr 29, 2019

Any word on whether or not this is going to be implemented? Hoping to finish OAuth integration with a provider that doesn't supply the email endpoint.

@pwcorbett
Copy link
Author

I have had no word. I'm hoping someone will look at it soon.

@pwcorbett
Copy link
Author

@xlson Could you review this?

@dtrejod
Copy link

dtrejod commented Jun 11, 2019

➕ 1 for getting this PRed. @torkelo, @bergquist seem active in this repo.

@marefr marefr added this to Ready For Review in Pull Requests (Contributions) via automation Jun 25, 2019
@marefr marefr added the prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 25, 2019
@okushchenko
Copy link
Contributor

@marefr can you take a look at this once again, please? This issue is really blocking an integration of Grafana with some OAuth providers.

@Lord-Y
Copy link

Lord-Y commented Sep 17, 2019

It's been a while since it's opened. Any plan to fix conflicts soon?

@pwcorbett
Copy link
Author

@Lord-Y Conflicts have been fixed.

@marefr marefr added area/backend prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. and removed prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 18, 2019
@marefr
Copy link
Member

marefr commented Sep 20, 2019

@pwcorbett thank you for the contribution. Currently the issue doesn't have a lot upvotes and we currently think that not having email returned from oauth provider is not a common thing. Therefore we're not going to accept this PR for now.

@okushchenko
Copy link
Contributor

@marefr it's the 7th most upvoted PR out of 100 open PRs, and the 21st most upvoted issue out of 2000 open issues. Moreover, the code change itself is pretty small.

@papagian papagian added the pr/external This PR is from external contributor label Oct 31, 2019
@stale
Copy link

stale bot commented Dec 11, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale Issue with no recent activity label Dec 11, 2019
@stale
Copy link

stale bot commented Jan 10, 2020

This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Jan 10, 2020
@haarchri
Copy link

haarchri commented Sep 3, 2020

any progress here ?

@jiangytcn
Copy link

What's the decision on this PR ?
The PR is quite useful as our Oauth server doesn't implement the emails endpoint

@cfenogli0
Copy link

Also looking for an update.

@MatthewMiles0
Copy link

Can this be reopened? This is clearly a wanted feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend pr/external This PR is from external contributor prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. stale Issue with no recent activity
Projects
No open projects
Pull Requests (Contributions)
  
Ready For Review
Development

Successfully merging this pull request may close these issues.

Generic OAuth support users without email