Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@grafana/runtime: expose config and loadPluginCss #17655

Merged
merged 6 commits into from Jun 19, 2019

Conversation

@ryantxu
Copy link
Member

ryantxu commented Jun 19, 2019

expose config and loadPluginCss via @grafana/runtime

ryantxu added 3 commits Jun 19, 2019
@ryantxu

This comment has been minimized.

Copy link
Member Author

ryantxu commented Jun 19, 2019

@dprokop -- any thoughts on how to get around this?
image

or alternative approach?

@dprokop

This comment has been minimized.

Copy link
Member

dprokop commented Jun 19, 2019

I would try add @types/system js and simply use import System from 'systemjs'; instead of direct import from dist file. This should help resolve this problem.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jun 19, 2019

CLA assistant check
All committers have signed the CLA.

@ryantxu ryantxu requested a review from torkelo Jun 19, 2019
hasUpdate: boolean;
}

export class Settings {

This comment has been minimized.

Copy link
@torkelo

torkelo Jun 19, 2019

Member

Would be good to take the time to change this type name to something config (as the file is called config). Maybe AppBootConfig or just GrafanaAppConfig or along that vein.

This comment has been minimized.

Copy link
@ryantxu

ryantxu Jun 19, 2019

Author Member

I renamed it GrafanaBootConfig :)

Copy link
Member

torkelo left a comment

just one minor comment otherwise good

ryantxu added 2 commits Jun 19, 2019
* grafana/master:
  Docs: Update readme to reference correct repo (#17666)
  LDAP: small improvements to various LDAP parts (#17662)
  Chore: Fix noImplicitAny issues (#17636)
  AddPanel: Fix issue when removing moved add panel widget  (#17659)
@ryantxu ryantxu merged commit 4281344 into grafana:master Jun 19, 2019
2 checks passed
2 checks passed
build-branches-and-prs Workflow: build-branches-and-prs
Details
license/cla Contributor License Agreement is signed.
Details
markelog added a commit that referenced this pull request Jun 20, 2019
* 'master' of github.com:grafana/grafana:
  Explore: Improves performance of Logs element by limiting re-rendering (#17685)
  Docs: Flag serve_from_sub_path as available in 6.3 (#17674)
  @grafana/runtime: expose config and loadPluginCss (#17655)
  noImplicitAny: Fix basic errors (#17668)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Jun 24, 2019
…-mapping-to-field

* grafana/master:
  Elasticsearch: Visualize logs in Explore (grafana#17605)
  Grafana-CLI: Wrapper for `grafana-cli` within RPM/DEB packages and config/homepath are now global flags (grafana#17695)
  Add guidelines for SQL date comparisons (grafana#17732)
  Docs: clarified usage of go get and go mod (grafana#17637)
  Project: Issue triage doc improvement (grafana#17709)
  Improvement: Grafana release process minor improvements (grafana#17661)
  TimePicker: New time picker dropdown & custom range UI (grafana#16811)
  RemoteCache: redis connection string parsing test (grafana#17702)
  Fix link in pkg/README (grafana#17714)
  Dashboard: Use Explore's Prometheus editor in dashboard panel edit (grafana#15364)
  Settings: Fix typo in defaults.ini (grafana#17707)
  Project: Adds a security policy (grafana#17698)
  Project: Adds support resource docs (grafana#17699)
  Document issue triage process (grafana#17669)
  noImplicitAny: slate (grafana#17681)
  config: fix connstr for remote_cache (grafana#17675)
  Explore: Improves performance of Logs element by limiting re-rendering (grafana#17685)
  Docs: Flag serve_from_sub_path as available in 6.3 (grafana#17674)
  @grafana/runtime: expose config and loadPluginCss (grafana#17655)
  noImplicitAny: Fix basic errors (grafana#17668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.