Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: Fixes so user can change HTTP Method in config settings #21055

Merged
merged 1 commit into from Dec 12, 2019
Merged

Prometheus: Fixes so user can change HTTP Method in config settings #21055

merged 1 commit into from Dec 12, 2019

Conversation

hugohaggmark
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #21004

Special notes for your reviewer:

@hugohaggmark hugohaggmark added this to the 6.5.3 milestone Dec 12, 2019
@hugohaggmark hugohaggmark self-assigned this Dec 12, 2019
@hugohaggmark hugohaggmark added this to In Review in Frontend Platform Backlog via automation Dec 12, 2019
peterholmberg
peterholmberg approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@peterholmberg peterholmberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aocenas
Copy link
Member

aocenas commented Dec 12, 2019

@hugohaggmark I think there is also an issue with this declaration here:

grafana/packages/grafana-data/src/types/select.ts

Line 9 in c194ae1

[key: string]: any;

Seems like because of the [key: string]: any; the SelectableValue conforms to any object and so can be passed on into function that expects SyntheticEvent.

Not sure if it makes sense to fix here, but should probably be changed to prevent this in the future.

@hugohaggmark
Copy link
Contributor Author

@hugohaggmark I think there is also an issue with this declaration here:

grafana/packages/grafana-data/src/types/select.ts

Line 9 in c194ae1

[key: string]: any;

Seems like because of the [key: string]: any; the SelectableValue conforms to any object and so can be passed on into function that expects SyntheticEvent.

Not sure if it makes sense to fix here, but should probably be changed to prevent this in the future.

Good catch @aocenas, we're in the progress of redoing the Select component so this could be valuable information for that task. (ping @dprokop)

@hugohaggmark hugohaggmark merged commit e69ec6c into master Dec 12, 2019
Frontend Platform Backlog automation moved this from In Review to Done Dec 12, 2019
@hugohaggmark hugohaggmark deleted the hugoh/bug-prom-httpsettings branch December 12, 2019 10:52
ryantxu pushed a commit to ryantxu/grafana that referenced this pull request Dec 23, 2019
@hugohaggmark @ryantxu
Prometheus: Fixes so user can change HTTP Method in config (grafana#2…
e22e257 
…1055)

Fixes grafana#21004
johntdyer pushed a commit to johntdyer/grafana that referenced this pull request Jan 2, 2020
@hugohaggmark @johntdyer
Prometheus: Fixes so user can change HTTP Method in config (grafana#2…
2da8cae 
…1055)

Fixes grafana#21004
aocenas pushed a commit that referenced this pull request Jan 14, 2020
@hugohaggmark @aocenas
Prometheus: Fixes so user can change HTTP Method in config (#21055)
90143ff 
Fixes #21004

(cherry picked from commit e69ec6c)
@aocenas aocenas mentioned this pull request Jan 14, 2020
Merged
aocenas pushed a commit that referenced this pull request Jan 15, 2020
@hugohaggmark @aocenas
Prometheus: Fixes so user can change HTTP Method in config (#21055)
7247f0f 
Fixes #21004

(cherry picked from commit e69ec6c)
paulfantom added a commit to paulfantom/grafana that referenced this pull request Jan 21, 2020
@paulfantom
Merge remote-tracking branch 'upstream/v6.5.x' into update
de9f106 
* upstream/v6.5.x: (559 commits)
  DataLinks: Make data links input grow again (grafana#21499)
  Release 6.5.3 version changes
  CloudWatch: dimension_values templating fix (grafana#21401)
  Build: package all binaries for enterprise (grafana#21381)
  Cloudwatch: Fixed crash when switching from cloudwatch data source (grafana#21376)
  Rendering: Fix panel PNG rendering when using sub url & serve_from_sub_path = true (grafana#21306)
  Units: support farenheit (existing misspelling) (grafana#21249)
  Docs: fixed broken doc link for graph and table panels (grafana#21238)
  Docs: fix of broken doc link in the dashlist panel's help section (grafana#21230)
  Docs: Update the link to docs for singlestat (grafana#21225)
  Table: Matches column names with unescaped regex characters (grafana#21164)
  DataLinks: Sanitize data/panel link URLs (grafana#21140)
  API: Validate redirect_to cookie has valid (Grafana) url  (grafana#21057)
  Prometheus: Prevents validation of inputs when clicking in them without changing the value (grafana#21059)
  Prometheus: Fixes so user can change HTTP Method in config (grafana#21055)
  Templating: Fixes default visibility for submenu to same as dashboard (grafana#21050)
  Fix: Shows SubMenu when filtering directly from table (grafana#21017)
  Elastic: Fix multiselect variable interpolation for logs (grafana#20894)
  release 6.5.2
  Prometheus: removes metric syntax (grafana#21003)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterholmberg peterholmberg peterholmberg approved these changes

Assignees

@hugohaggmark hugohaggmark

Labels
add to changelog datasource/Prometheus type/bug
Projects
None yet
Milestone
6.5.3
Development

Successfully merging this pull request may close these issues.

Prometheus datasource cannot change HTTP method
3 participants
@hugohaggmark @aocenas @peterholmberg