Template variables: Add error for failed query variable on time range update #21731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
approved these changes
Jan 24, 2020
xlson
pushed a commit
that referenced
this pull request
Jan 27, 2020
(cherry picked from commit 4c41d7e)
xlson
pushed a commit
that referenced
this pull request
Jan 27, 2020
(cherry picked from commit 4c41d7e)
ying-jeanne
added
pr/external
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21680 (ish)
We decided that the best current solution would be to display an error as the query variable query fails. Any thoughts on alternative solutions?