Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back scripts evaluation in TextPanel #26413

Merged
merged 1 commit into from Jul 17, 2020
Merged

Conversation

dprokop
Copy link
Member

@dprokop dprokop commented Jul 17, 2020

Fixes #26406

Brings in https://github.com/christo-pr/dangerously-set-html-content and defines typing for it (will open a PR with typing for that library ltr).

@dprokop dprokop added this to the 7.1.1 milestone Jul 17, 2020
@dprokop dprokop requested review from daniellee, ryantxu and a team July 17, 2020 15:36
@dprokop dprokop self-assigned this Jul 17, 2020
@dprokop dprokop requested review from torkelo and hugohaggmark and removed request for a team July 17, 2020 15:36
@dprokop dprokop added this to In Review in Frontend Platform Backlog via automation Jul 17, 2020
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dprokop dprokop merged commit 718b78c into master Jul 17, 2020
Frontend Platform Backlog automation moved this from In Review to Done Jul 17, 2020
@dprokop dprokop deleted the text-panel-script-alt branch July 17, 2020 16:01
@daniellee
Copy link
Contributor

Nice work @dprokop

@topnessman
Copy link

Hello!

When will this bug fix be released? Thanks!

xlson pushed a commit that referenced this pull request Jul 24, 2020
@xlson xlson mentioned this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom JS tabs menu not responding since move to 7.1.0 (from 6.6.2)
5 participants