Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureMonitor: map more units #26990

Merged
merged 2 commits into from Aug 13, 2020
Merged

AzureMonitor: map more units #26990

merged 2 commits into from Aug 13, 2020

Conversation

@kylebrandt
Copy link
Contributor

@kylebrandt kylebrandt commented Aug 13, 2020

What this PR does / why we need it:
More Azure monitor units need to be mapped to their Grafana values. In particular BitsPerSecond, but should take care of everything listed in https://docs.microsoft.com/en-us/rest/api/monitor/metrics/list#unit

- fix link
@kylebrandt kylebrandt marked this pull request as ready for review Aug 13, 2020
@kylebrandt kylebrandt requested a review from grafana/backend-platform as a code owner Aug 13, 2020
@kylebrandt kylebrandt requested review from aknuds1 and wbrowne and removed request for grafana/backend-platform Aug 13, 2020
@aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Aug 13, 2020

Is this still WIP?

Copy link
Contributor

@aknuds1 aknuds1 left a comment

LGTM

@kylebrandt kylebrandt changed the title AzureMonitor: map more units (wip) AzureMonitor: map more units Aug 13, 2020
@kylebrandt kylebrandt added this to the 7.1.4 milestone Aug 13, 2020
@kylebrandt kylebrandt merged commit f9f60c9 into master Aug 13, 2020
2 checks passed
2 checks passed
continuous-integration/drone/pr Build is passing
Details
license/cla Contributor License Agreement is signed.
Details
@kylebrandt kylebrandt deleted the azMonUnit branch Aug 13, 2020
aknuds1 added a commit that referenced this pull request Aug 14, 2020
add BitsPerSecond and Seconds
aknuds1 added a commit that referenced this pull request Aug 20, 2020
add BitsPerSecond and Seconds

(cherry picked from commit f9f60c9)
wbrowne added a commit that referenced this pull request Aug 20, 2020
add BitsPerSecond and Seconds

(cherry picked from commit f9f60c9)
@wbrowne wbrowne mentioned this pull request Aug 20, 2020
wbrowne added a commit that referenced this pull request Aug 20, 2020
add BitsPerSecond and Seconds

(cherry picked from commit f9f60c9)
@aknuds1 aknuds1 mentioned this pull request Aug 20, 2020
marcusolsson added a commit to marcusolsson/grafana that referenced this pull request Sep 22, 2020
add BitsPerSecond and Seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants