Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureMonitor: Change filterDimensions property to match what is stored #27459

Merged
merged 3 commits into from Sep 8, 2020

Conversation

@kylebrandt
Copy link
Contributor

@kylebrandt kylebrandt commented Sep 8, 2020

What this PR does / why we need it:
Changes the dimensionsFilters property to dimensionsFilter in the Azure Monitor Datasource's AzureMonitor service to make what is sent to match the saved model.

Before this, the property that the backend was expecting was not available in the case of alerting, where the stored model is fetched.

@kylebrandt kylebrandt requested review from ryantxu and Elfo404 Sep 8, 2020
@kylebrandt kylebrandt requested a review from grafana/backend-platform as a code owner Sep 8, 2020
@kylebrandt kylebrandt requested review from wbrowne and jessabe and removed request for grafana/backend-platform Sep 8, 2020
@ryantxu
ryantxu approved these changes Sep 8, 2020
Copy link
Member

@ryantxu ryantxu left a comment

ahhh consistency!

kylebrandt added 2 commits Sep 8, 2020
@kylebrandt kylebrandt added this to the 7.2 milestone Sep 8, 2020
@Elfo404
Elfo404 approved these changes Sep 8, 2020
Copy link
Contributor

@Elfo404 Elfo404 left a comment

Awesome! I just tested it and this will also fix part of #27354 (dimension filters were interpolated correctly)

@kylebrandt kylebrandt merged commit 9bab551 into master Sep 8, 2020
2 checks passed
2 checks passed
continuous-integration/drone/pr Build is passing
Details
license/cla Contributor License Agreement is signed.
Details
@kylebrandt kylebrandt deleted the azureDimensionFilters branch Sep 8, 2020
@marefr marefr changed the title AzureMonitor: change filterDimensions property to match what is stored AzureMonitor: Change filterDimensions property to match what is stored Sep 9, 2020
@marefr marefr added the type/bug label Sep 9, 2020
marcusolsson added a commit to marcusolsson/grafana that referenced this pull request Sep 22, 2020
grafana#27459)

Changes the dimensionsFilters property to dimensionsFilter in the Azure Monitor Datasource's AzureMonitor service to make what is sent to match the saved model.

Before this, the property that the backend was expecting was not available in the case of alerting, where the stored model is fetched.

This also fixes a panic when there is a dimension alias but no dimension
ryantxu added a commit that referenced this pull request Nov 18, 2020
#27459)

Changes the dimensionsFilters property to dimensionsFilter in the Azure Monitor Datasource's AzureMonitor service to make what is sent to match the saved model.

Before this, the property that the backend was expecting was not available in the case of alerting, where the stored model is fetched.

This also fixes a panic when there is a dimension alias but no dimension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants