Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureMonitor: Pass through null values instead of setting 0 #28126

Merged
merged 1 commit into from Oct 9, 2020
Merged

Conversation

@kylebrandt
Copy link
Contributor

@kylebrandt kylebrandt commented Oct 8, 2020

What this PR does / why we need it:
For the Azure Monitor service in the Azure Monitor datasource, if values were null the backend set them to zero. They will now be null instead.

Before:
image

After:
image

(One could still use "Null point mode: null as zero" if one wants to make it look like it did before)

Which issue(s) this PR fixes:

Fixes #28001

Special notes for your reviewer:

fixes #28001
@kylebrandt kylebrandt added this to the 7.3 milestone Oct 8, 2020
@kylebrandt kylebrandt requested review from aknuds1 and marefr Oct 8, 2020
@kylebrandt kylebrandt marked this pull request as ready for review Oct 8, 2020
@kylebrandt kylebrandt requested a review from grafana/backend-platform as a code owner Oct 8, 2020
@marefr
marefr approved these changes Oct 8, 2020
Copy link
Member

@marefr marefr left a comment

LGTM

@al-lac
al-lac approved these changes Oct 9, 2020
@kylebrandt kylebrandt merged commit c9a5d1a into master Oct 9, 2020
6 checks passed
6 checks passed
Analyze (javascript)
Details
Analyze (go)
Details
Analyze (python)
Details
CodeQL No new alerts
Details
continuous-integration/drone/pr Build is passing
Details
license/cla Contributor License Agreement is signed.
Details
@kylebrandt kylebrandt deleted the azMonNull branch Oct 9, 2020
@wbrowne wbrowne changed the title AzureMonitor: pass through null values instead of setting 0 AzureMonitor: Pass through null values instead of setting 0 Oct 14, 2020
@wbrowne wbrowne mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants