Prometheus: Fix link to Prometheus graph in dashboard #29543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
davkal,
zoltanbedi and
torkelo
and removed request for
a team and
torkelo
zoltanbedi
reviewed
Dec 2, 2020
| @@ -18,6 +18,14 @@ interface State { | |||
| export default class PromLink extends Component<Props, State> { | |||
There was a problem hiding this comment.
Would it be too much to ask to refactor this component to a function component? 😄
2 things I noticed
- the same logic is used in componentDidMount and componentDidUpdate
- getExternalLink is async because?
There was a problem hiding this comment.
No, not much work at all. And you are totally right ⭐️ - leave the code in better shape than.... So I refactored it to hooks + as I was adding tests, I switched to react-testing-library. 🙂
There was a problem hiding this comment.
Also async was not necessary.
zoltanbedi
approved these changes
Dec 3, 2020
ivanahuckova
added this to Under review
in Observability (deprecated, use Observability Squad)
via automation
Observability (deprecated, use Observability Squad)
automation
moved this from Under review
to Done
Dec 4, 2020
ryantxu
pushed a commit
that referenced
this pull request
Dec 8, 2020
* Fix Promlink to have href after componentDidMount * Refactor to hooks and react testing library * Update * Update snapshot test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The href was set only in componentDidUpdate. Therefore to have href correct, you've had to interact with editor. This PR fixes it + adds test coverage.
Which issue(s) this PR fixes:
Fixes #29444