Configuration: Fix changing org preferences in FireFox #35549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugohaggmark
added
type/bug
area/admin/user
add to changelog
area/configuration
hugohaggmark
requested review from
a team,
mckn and
oscarkilhed
and removed request for
a team
hugohaggmark
changed the title
dprokop
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Good catch @hugohaggmark, this looks good and works as expected.
hugohaggmark
added
the
old backport v8.0.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-35549-to-v8.0.x origin/v8.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1838e6b7749ba291c5c2d44fe8e8f20338d05372
# Push it to GitHub
git push --set-upstream origin backport-35549-to-v8.0.x
git switch main
# Remove the local backport branch
git branch -D backport-35549-to-v8.0.xThen, create a pull request where the |
grafanabot
pushed a commit
that referenced
this pull request
Jun 11, 2021
(cherry picked from commit 1838e6b)
hugohaggmark
added a commit
that referenced
this pull request
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
What I could find was that we were reloading the window before the result was received from the backend which resulted in
NS_BINDING_ABORTEDerror in FireFox. This PR adds an await before reloading the page.Which issue(s) this PR fixes:
Fixes #35503
Special notes for your reviewer: