[MYSQL] convert explicitely smallint and tinyint #35897
Conversation
ying-jeanne
requested review from
wbrowne and
marefr
and removed request for
a team
grafanabot
added
datasource/MySQL
area/backend
datasource/MSSQL
There was a problem hiding this comment.
Looks good I think. Added some comments and a suggestion to get the CI to not run mysql_tests during the integration tests when database is sqlite.
To avoid this kind of issue, maybe it makes more sense to think about enhance convert value to float64 to support also string type?
Maybe. Is the type really string, isn't it string array? If you would like to evaluate that, please push changes to this PR or open an alternative PR so that we can understand what it actually means in terms of code and changes.
i think this fix is urgent, let's fix the issue and i would create a ticket for the improvement, we can discuss that next week. |
|
Are these specifically for NULLABLE smallint / tinyint? will this also work for non-nullable columns with these types? |
they are working for both nullable and no nullable. |
ying-jeanne
added
the
old backport v8.0.x
* [MYSQL] convert explicitely smallint and tinyint * clean up code * fix comments (cherry picked from commit 73fdd9d)
* [MYSQL] convert explicitely smallint and tinyint * clean up code * fix comments
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #35876
Special notes for your reviewer:
seems when smallint or tinyint is nullable or not would impact its scantype. when they are nullable, scantype becomes nullableint64, for which we would generate the default string converter.