live: Add support to handle origin without a value for the port when matching with root_url #36834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FZambia
requested review from
wbrowne and
ying-jeanne
and removed request for
a team
FZambia
changed the title
FZambia
added
add to changelog
old backport v8.0.x
ryantxu
approved these changes
Jul 16, 2021
grafanabot
pushed a commit
that referenced
this pull request
Jul 17, 2021
(cherry picked from commit 37caebc)
FZambia
added a commit
that referenced
this pull request
Jul 18, 2021
achatterjee-grafana
changed the title
wbrowne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Origin without explicit port should pass a check when compared with root_url.
Which issue(s) this PR fixes:
#36822