New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue that produced State timeline panel tooltip error when data was not in sync. #39438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoltanbedi
requested review from
jackw and
leeoniya
and removed request for
a team and
jackw
September 20, 2021 15:54
zoltanbedi
added
area/panel/state-timeline
old backport v8.1.x
Mark PR for automatic backport to v8.1.x
old backport v8.2.x
Mark PR for automatic backport to v8.2.x
type/bug
labels
Sep 20, 2021
dprokop
reviewed
Sep 21, 2021
public/app/plugins/panel/state-timeline/StateTimelineTooltip.tsx
Outdated
Show resolved
Hide resolved
dprokop
approved these changes
Sep 21, 2021
leeoniya
approved these changes
Sep 27, 2021
grafanabot
pushed a commit
that referenced
this pull request
Sep 27, 2021
) * Fix: State timeline panel tooltip error when data is not in sync * Move check from tooltip to panel (cherry picked from commit 24475cf)
grafanabot
pushed a commit
that referenced
this pull request
Sep 27, 2021
) * Fix: State timeline panel tooltip error when data is not in sync * Move check from tooltip to panel (cherry picked from commit 24475cf)
achatterjee-grafana
changed the title
Fix: State timeline panel tooltip error when data is not in sync
Fixed an issue that produced State timeline panel tooltip error when data was not in sync.
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/frontend
area/panel/state-timeline
old backport v8.1.x
Mark PR for automatic backport to v8.1.x
old backport v8.2.x
Mark PR for automatic backport to v8.2.x
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR resolves the issue around state timeline panel's tooltip when data is out of sync.
statetimeline-bug.mp4
statetimeline-fix.mp4
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/support-escalations/issues/932
Special notes for your reviewer:
Repro step:
I've used the tns-demo to generate data.
Panel json