Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panels: Prevent panel content from escaping its bounds #52167

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

kaydelaney
Copy link
Contributor

What this PR does / why we need it:
Adds contain: strict; to .panel-content to prevent panel content escaping its bounds, which could previously be used in conjunction with the text panel and position: fixed;, for example, to arbitrarily place content on the screen.

Special notes for your reviewer:
As a bonus side-effect, contain:strict; could have minor performance benefits by allowing browsers to do less work

@kaydelaney kaydelaney added this to the 9.0.3 milestone Jul 13, 2022
@kaydelaney kaydelaney requested a review from a team July 13, 2022 15:46
@kaydelaney kaydelaney self-assigned this Jul 13, 2022
@kaydelaney kaydelaney requested review from joshhunt and JoaoSilvaGrafana and removed request for a team July 13, 2022 15:46
@grafanabot
Copy link
Contributor

Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kaydelaney kaydelaney merged commit 3131d12 into main Jul 14, 2022
@kaydelaney kaydelaney deleted the panel-contain branch July 14, 2022 10:17
grafanabot pushed a commit that referenced this pull request Jul 14, 2022
kaydelaney added a commit that referenced this pull request Jul 14, 2022
(cherry picked from commit 3131d12)

Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>
@torkelo
Copy link
Member

torkelo commented Jul 19, 2022

@kaydelaney we should probably add this to https://github.com/grafana/grafana/blob/main/packages/grafana-ui/src/components/PanelChrome/PanelChrome.tsx#L109

as that is used in PanelEditor view table (via PanelRenderer) and in scenes, ML app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants