Panels: Prevent panel content from escaping its bounds#52167
Merged
Conversation
kaydelaney
added
area/dashboard
area/frontend
area/panel/text
oss-user-essentials
no-changelog
kaydelaney
requested review from
JoaoSilvaGrafana and
joshhunt
and removed request for
a team
Contributor
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/26047 |
grafanabot
pushed a commit
that referenced
this pull request
Jul 14, 2022
(cherry picked from commit 3131d12)
kaydelaney
added a commit
that referenced
this pull request
Jul 14, 2022
bohandley
pushed a commit
that referenced
this pull request
Jul 14, 2022
Contributor
|
@kaydelaney we should probably add this to https://github.com/grafana/grafana/blob/main/packages/grafana-ui/src/components/PanelChrome/PanelChrome.tsx#L109 as that is used in PanelEditor view table (via PanelRenderer) and in scenes, ML app |
PoorlyDefinedBehaviour
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
contain: strict;to.panel-contentto prevent panel content escaping its bounds, which could previously be used in conjunction with the text panel andposition: fixed;, for example, to arbitrarily place content on the screen.Special notes for your reviewer:
As a bonus side-effect,
contain:strict;could have minor performance benefits by allowing browsers to do less work