Browse: Hide dashboard actions if user does not have enough permission #55218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpskdl
added
type/bug
area/dashboard
area/search
add to changelog
backport v9.1.x
lpskdl
requested review from
joshhunt,
ashharrison90 and
dprokop
and removed request for
a team
JoaoSilvaGrafana
approved these changes
Sep 15, 2022
|
|
||
| const { rerender, store } = await setup(); | ||
|
|
||
| expect(screen.queryByRole('button', { name: /new/i })).not.toBeInTheDocument(); |
There was a problem hiding this comment.
Nitpicky but I didn't notice that this one test was both testing for having permissions and not having permissions, should we separate this into 2 tests so its easier to understand what each of them does? Or alternatively change the title to reflect that it is testing both scenarios
axelavargas
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
this looks great @lpskdl 👏🏾 , thanks for fixing this, and awesome job with the unit test!!
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/33692 |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-55218-to-v9.1.x origin/v9.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 896d684065bad1fb21fc39afb9f101bf76dd1a37
# Push it to GitHub
git push --set-upstream origin backport-55218-to-v9.1.x
git switch main
# Remove the local backport branch
git branch -D backport-55218-to-v9.1.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will hide the dashboard actions when user doesn't have enough permission.
Screen.Recording.2022-09-15.at.10.48.36.mov
Which issue(s) this PR fixes:
Fixes #55216
Special notes for your reviewer: