Make tooltip shareable like crosshair #6274

Merged
merged 1 commit into from Dec 6, 2016

Projects

None yet

5 participants

@connection-reset
Contributor

No description provided.

@CLAassistant
CLAassistant commented Oct 14, 2016 edited

CLA assistant check
All committers have signed the CLA.

@bergquist
Contributor
bergquist commented Oct 18, 2016 edited

@connection-reset Please sign the CLA.

@connection-reset
Contributor
@connection-reset
Contributor

rebased and squashed commits

@connection-reset @connection-reset connection-reset Make tooltip shareable like crosshair
e6c8e75
@torkelo torkelo self-assigned this Dec 6, 2016
@torkelo torkelo added this to the 4.1.0 milestone Dec 6, 2016
@torkelo torkelo merged commit e6c8e75 into grafana:master Dec 6, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
licence/cla Contributor License Agreement is signed.
Details
@torkelo torkelo added a commit that referenced this pull request Dec 6, 2016
@torkelo torkelo changelog(): updated changelog with info on shared tooltip feature me…
…rged via PR #6274, closes #1578
e1b25b3
@torkelo
Member
torkelo commented Dec 6, 2016

Merged this to master after a few changes and refactorings. There is now only one option (named Shared Tooltip), currently using the old property sharedCrosshair (will rename later if there is no major complaints).

Figured there was no great need to have two options (sharedCrosshair & sharedTooltip), so will try to only have one (that does both), and get some feedback on that.

@towolf
towolf commented Dec 6, 2016 edited

Please do not replace the old functionality, too many pop-ups for one screen on my high density dashboards ...

This looked bugged to me until I found this PR.

Let them press Space, or Ctrl, or something.

@connection-reset
Contributor

@towolf you can disable this in dashboard settings.

@torkelo
Member
torkelo commented Dec 7, 2016

or with CTRL/MOD+O , but if there is a good argument to have these as separate options (shared cross & shared tooltip), then that's good to know, maybe it's worth two options

@towolf
towolf commented Dec 7, 2016 edited

@connection-reset @torkelo Shared cross-hair was not a make-or-break feature, But I would not like to lose this, just because shared tooltips do not work for me ...

If you can support both, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment