New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tooltip shareable like crosshair #6274

Merged
merged 1 commit into from Dec 6, 2016

Conversation

Projects
None yet
5 participants
@connection-reset
Contributor

connection-reset commented Oct 14, 2016

No description provided.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Oct 14, 2016

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Oct 14, 2016

CLA assistant check
All committers have signed the CLA.

@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Oct 18, 2016

Contributor

@connection-reset Please sign the CLA.

Contributor

bergquist commented Oct 18, 2016

@connection-reset Please sign the CLA.

@connection-reset

This comment has been minimized.

Show comment
Hide comment
@connection-reset

connection-reset Oct 18, 2016

Contributor
Contributor

connection-reset commented Oct 18, 2016

@connection-reset

This comment has been minimized.

Show comment
Hide comment
@connection-reset

connection-reset Nov 4, 2016

Contributor

rebased and squashed commits

Contributor

connection-reset commented Nov 4, 2016

rebased and squashed commits

@torkelo torkelo self-assigned this Dec 6, 2016

@torkelo torkelo added this to the 4.1.0 milestone Dec 6, 2016

@torkelo torkelo merged commit e6c8e75 into grafana:master Dec 6, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
licence/cla Contributor License Agreement is signed.
Details

torkelo added a commit that referenced this pull request Dec 6, 2016

torkelo added a commit that referenced this pull request Dec 6, 2016

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Dec 6, 2016

Member

Merged this to master after a few changes and refactorings. There is now only one option (named Shared Tooltip), currently using the old property sharedCrosshair (will rename later if there is no major complaints).

Figured there was no great need to have two options (sharedCrosshair & sharedTooltip), so will try to only have one (that does both), and get some feedback on that.

Member

torkelo commented Dec 6, 2016

Merged this to master after a few changes and refactorings. There is now only one option (named Shared Tooltip), currently using the old property sharedCrosshair (will rename later if there is no major complaints).

Figured there was no great need to have two options (sharedCrosshair & sharedTooltip), so will try to only have one (that does both), and get some feedback on that.

@towolf

This comment has been minimized.

Show comment
Hide comment
@towolf

towolf Dec 6, 2016

Contributor

Please do not replace the old functionality, too many pop-ups for one screen on my high density dashboards ...

This looked bugged to me until I found this PR.

Let them press Space, or Ctrl, or something.

Contributor

towolf commented Dec 6, 2016

Please do not replace the old functionality, too many pop-ups for one screen on my high density dashboards ...

This looked bugged to me until I found this PR.

Let them press Space, or Ctrl, or something.

@connection-reset

This comment has been minimized.

Show comment
Hide comment
@connection-reset

connection-reset Dec 7, 2016

Contributor

@towolf you can disable this in dashboard settings.

Contributor

connection-reset commented Dec 7, 2016

@towolf you can disable this in dashboard settings.

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Dec 7, 2016

Member

or with CTRL/MOD+O , but if there is a good argument to have these as separate options (shared cross & shared tooltip), then that's good to know, maybe it's worth two options

Member

torkelo commented Dec 7, 2016

or with CTRL/MOD+O , but if there is a good argument to have these as separate options (shared cross & shared tooltip), then that's good to know, maybe it's worth two options

@towolf

This comment has been minimized.

Show comment
Hide comment
@towolf

towolf Dec 7, 2016

Contributor

@connection-reset @torkelo Shared cross-hair was not a make-or-break feature, But I would not like to lose this, just because shared tooltips do not work for me ...

If you can support both, please do!

Contributor

towolf commented Dec 7, 2016

@connection-reset @torkelo Shared cross-hair was not a make-or-break feature, But I would not like to lose this, just because shared tooltips do not work for me ...

If you can support both, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment