New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) add LINE notify to notifier #7301

Merged
merged 1 commit into from Jan 19, 2017

Conversation

Projects
None yet
2 participants
@huydx
Contributor

huydx commented Jan 19, 2017

add LINE to notifier

LINE is very famous chat message at many asia countries (japan/taiwan/thai...). Adding notification to LINE will help user in those countries to access information better. The implement come from a service from LINE called LINE notify (which implement light-weight notification method): https://notify-bot.line.me/en/

About LINE: http://line.me/
How it looks:

@huydx

This comment has been minimized.

Show comment
Hide comment
@huydx

huydx Jan 19, 2017

Contributor

@bergquist I fixed using latest upstream, can you take a look :). (created another PR because of some rebase problem :( )

Contributor

huydx commented Jan 19, 2017

@bergquist I fixed using latest upstream, can you take a look :). (created another PR because of some rebase problem :( )

@@ -63,6 +64,12 @@ func sendWebRequestSync(ctx context.Context, webhook *Webhook) error {
request.Header.Add("Authorization", util.GetBasicAuthHeader(webhook.User, webhook.Password))
}
if len(webhook.HttpHeader) != 0 {

This comment has been minimized.

@bergquist

bergquist Jan 19, 2017

Contributor

This if statement can be removed. If webhook.HttpHeader is empty the loop wont do anything

https://play.golang.org/p/Wc_ajoYUfh

@bergquist

bergquist Jan 19, 2017

Contributor

This if statement can be removed. If webhook.HttpHeader is empty the loop wont do anything

https://play.golang.org/p/Wc_ajoYUfh

This comment has been minimized.

@bergquist

bergquist Jan 19, 2017

Contributor

Fixed it myself and merged. Awesome work!

@bergquist

bergquist Jan 19, 2017

Contributor

Fixed it myself and merged. Awesome work!

@bergquist bergquist merged commit 376d2d5 into grafana:master Jan 19, 2017

1 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
licence/cla Contributor License Agreement is signed.
Details
@huydx

This comment has been minimized.

Show comment
Hide comment
@huydx

huydx Jan 19, 2017

Contributor

thanks @bergquist a lot!!!

Contributor

huydx commented Jan 19, 2017

thanks @bergquist a lot!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment