New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included LIMIT, SLIMIT and ORDER BY time for influxdb #6065 #7735
Conversation
Initial work for the query builder interface
This should also close #7232 |
Feedback:
|
The order by time is applied in the query before the LIMIT, so the effect is basically X first points or X last points in time.So if you don't have this implemented LIMIT will only apply for the X first points since the default for influx is ASC, so if you want the most recent data to be used with LIMIT you must use order by time desc. |
If you fix the ux for the ORDER BY then I think this is good to merge. Nice work! |
It should be fine now, let me know if there is any other changed necessary. |
Thanks again @thuck Fourth PR this week! Great to get TOPN functionality for InfluxDB in Grafana. |
inclined to revert this change. Just messes up the editor so much with options that you don't use 99.99% of the time. Maybe make the raw query editor mode better would make more sense? |
@torkelo Maybe you can keep it as it is, considering that influxdb will change their query language again not sure if put more effort on the current one is a good investment of time. |
Fixes #6065