From bfd407c2c37bf47f52abc1e494bd577adf78a1ae Mon Sep 17 00:00:00 2001 From: Leon Sorokin Date: Mon, 26 Feb 2024 21:55:48 -0600 Subject: [PATCH] remove LayoutItemContext from AnnotationEditor2 and AnnotationTooltip2 --- .../plugins/annotations2/AnnotationEditor2.tsx | 17 ++--------------- .../plugins/annotations2/AnnotationTooltip2.tsx | 7 ++----- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationEditor2.tsx b/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationEditor2.tsx index 1e01344b4634..702711454e40 100644 --- a/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationEditor2.tsx +++ b/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationEditor2.tsx @@ -1,19 +1,9 @@ import { css } from '@emotion/css'; -import React, { useContext, useEffect, useRef } from 'react'; +import React, { useRef } from 'react'; import { useAsyncFn, useClickAway } from 'react-use'; import { AnnotationEventUIModel, GrafanaTheme2, dateTimeFormat, systemDateFormats } from '@grafana/data'; -import { - Button, - Field, - Form, - HorizontalGroup, - InputControl, - LayoutItemContext, - TextArea, - usePanelContext, - useStyles2, -} from '@grafana/ui'; +import { Button, Field, Form, HorizontalGroup, InputControl, TextArea, usePanelContext, useStyles2 } from '@grafana/ui'; import { TagFilter } from 'app/core/components/TagFilter/TagFilter'; import { getAnnotationTags } from 'app/features/annotations/api'; @@ -37,9 +27,6 @@ export const AnnotationEditor2 = ({ annoVals, annoIdx, dismiss, timeZone, ...oth useClickAway(clickAwayRef, dismiss); - const layoutCtx = useContext(LayoutItemContext); - useEffect(() => layoutCtx.boostZIndex(), [layoutCtx]); - const [createAnnotationState, createAnnotation] = useAsyncFn(async (event: AnnotationEventUIModel) => { const result = await onAnnotationCreate!(event); dismiss(); diff --git a/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationTooltip2.tsx b/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationTooltip2.tsx index 0b72deb99f27..c8c3deec3195 100644 --- a/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationTooltip2.tsx +++ b/public/app/plugins/panel/timeseries/plugins/annotations2/AnnotationTooltip2.tsx @@ -1,8 +1,8 @@ import { css } from '@emotion/css'; -import React, { useContext, useEffect } from 'react'; +import React from 'react'; import { GrafanaTheme2, dateTimeFormat, systemDateFormats, textUtil } from '@grafana/data'; -import { HorizontalGroup, IconButton, LayoutItemContext, Tag, usePanelContext, useStyles2 } from '@grafana/ui'; +import { HorizontalGroup, IconButton, Tag, usePanelContext, useStyles2 } from '@grafana/ui'; import alertDef from 'app/features/alerting/state/alertDef'; interface Props { @@ -25,9 +25,6 @@ export const AnnotationTooltip2 = ({ annoVals, annoIdx, timeZone, onEdit }: Prop const canEdit = canEditAnnotations(dashboardUID); const canDelete = canDeleteAnnotations(dashboardUID) && onAnnotationDelete != null; - const layoutCtx = useContext(LayoutItemContext); - useEffect(() => layoutCtx.boostZIndex(), [layoutCtx]); - const timeFormatter = (value: number) => dateTimeFormat(value, { format: systemDateFormats.fullDate,