New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new notifier : DingTalk #8473

Merged
merged 10 commits into from Jul 4, 2017

Conversation

Projects
None yet
7 participants
@jiamliang
Contributor

jiamliang commented May 26, 2017

Add a new notifier : DingTalk
DingTalk known as DingDing in China :
https://www.dingtalk.com/en/?spm=a3140.7858860.2231601.1.bBkEn7

We need Grafana send alert to DingDing(钉钉) .

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant May 26, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented May 26, 2017

CLA assistant check
All committers have signed the CLA.

jiamliang added some commits May 26, 2017

Merge branch 'master' of github.com:jiamliang/grafana
Conflicts:
	pkg/services/alerting/notifiers/dingding_test.go
@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee May 26, 2017

Member

Run gofmt -s -d ./pkg to see what code is causing the go format error.

Member

daniellee commented May 26, 2017

Run gofmt -s -d ./pkg to see what code is causing the go format error.

@jiamliang

This comment has been minimized.

Show comment
Hide comment
@jiamliang

jiamliang May 27, 2017

Contributor

@daniellee
I have modify the code, and no output after running gofmt -s -d ./pkg

[root@atlas-data grafana]# gofmt -s -d ./pkg
[root@atlas-data grafana]#

but, tests failed all the same.

Contributor

jiamliang commented May 27, 2017

@daniellee
I have modify the code, and no output after running gofmt -s -d ./pkg

[root@atlas-data grafana]# gofmt -s -d ./pkg
[root@atlas-data grafana]#

but, tests failed all the same.

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee May 30, 2017

Member

One of the tests has a build error:

FAIL	github.com/grafana/grafana/pkg/services/alerting/notifiers [build failed]
Member

daniellee commented May 30, 2017

One of the tests has a build error:

FAIL	github.com/grafana/grafana/pkg/services/alerting/notifiers [build failed]
@jiamliang

This comment has been minimized.

Show comment
Hide comment
@jiamliang

jiamliang May 31, 2017

Contributor

@daniellee Thanks a lot.

Contributor

jiamliang commented May 31, 2017

@daniellee Thanks a lot.

@dikang123

This comment has been minimized.

Show comment
Hide comment
@dikang123

dikang123 Jun 14, 2017

when will this feature release? @daniellee @jiamliang

dikang123 commented Jun 14, 2017

when will this feature release? @daniellee @jiamliang

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee Jun 14, 2017

Member

@dikang123 it will probably be included in the next release of Grafana, v4.4.0, in a few weeks time.

Member

daniellee commented Jun 14, 2017

@dikang123 it will probably be included in the next release of Grafana, v4.4.0, in a few weeks time.

@firesh

This comment has been minimized.

Show comment
Hide comment
@firesh

firesh Jun 23, 2017

Excellent supporting DingTalk!

firesh commented Jun 23, 2017

Excellent supporting DingTalk!

@lyonliquid

This comment has been minimized.

Show comment
Hide comment
@lyonliquid

lyonliquid Jun 30, 2017

Wonderful! I'm looking forward to this feature!

lyonliquid commented Jun 30, 2017

Wonderful! I'm looking forward to this feature!

@daniellee daniellee added this to the 4.4.0 milestone Jul 4, 2017

@daniellee daniellee merged commit 109fd99 into grafana:master Jul 4, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee Jul 4, 2017

Member

This will be released in the 4.4.0 release. Thanks for the PR!

Member

daniellee commented Jul 4, 2017

This will be released in the 4.4.0 release. Thanks for the PR!

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee

daniellee Jul 4, 2017

Member

Are there any instructions for using this notifier? Would it be possible to add a placeholder in the url field that shows what the url looks like? Here is an example from the Sensu notifier:

image

Member

daniellee commented Jul 4, 2017

Are there any instructions for using this notifier? Would it be possible to add a placeholder in the url field that shows what the url looks like? Here is an example from the Sensu notifier:

image

@lyonliquid

This comment has been minimized.

Show comment
Hide comment
@lyonliquid

lyonliquid Jul 5, 2017

https://open.dingtalk.com/
We visit this website to learn how to use dingtalk,but unfortunately there is only Chinese edition. @daniellee

lyonliquid commented Jul 5, 2017

https://open.dingtalk.com/
We visit this website to learn how to use dingtalk,but unfortunately there is only Chinese edition. @daniellee

@zhengheyi

This comment has been minimized.

Show comment
Hide comment
@zhengheyi

zhengheyi Jul 7, 2017

@jiamliang how to use dingding in grafana ? URL应该怎样填写?

zhengheyi commented Jul 7, 2017

@jiamliang how to use dingding in grafana ? URL应该怎样填写?

@jiamliang

This comment has been minimized.

Show comment
Hide comment
@jiamliang

jiamliang Jul 10, 2017

Contributor

Yes, there is only Chinese edition.
https://open-doc.dingtalk.com/docs/doc.htm?spm=a219a.7629140.0.0.p2lr6t&treeId=257&articleId=105733&docType=1

In DingTalk PC Client:

  1. Click "more" icon on left bottom of the panel
  2. Click "Robot Manage" item in the pop menu, there will be a new panel call "Robot Manage"
  3. in the "Robot Manage" panel, select "customised: customised robot with Webhook"
  4. in the next new panel named "robot detail", click "Add" button.
  5. in "Add Robot" panel, input a nickname for the robot and select a "message group" which the robot will join in. click "next".
  6. there will be a Webhook URL in the panel, looks like this: https://oapi.dingtalk.com/robot/send?access_token=xxxxxxxxx. copy this URL to the grafana Dingtalk setting page and then click "finish" bottom.

Dingtalk supports the following "message type": text, link and markdown. this plugin only supports sending "text" message.

Contributor

jiamliang commented Jul 10, 2017

Yes, there is only Chinese edition.
https://open-doc.dingtalk.com/docs/doc.htm?spm=a219a.7629140.0.0.p2lr6t&treeId=257&articleId=105733&docType=1

In DingTalk PC Client:

  1. Click "more" icon on left bottom of the panel
  2. Click "Robot Manage" item in the pop menu, there will be a new panel call "Robot Manage"
  3. in the "Robot Manage" panel, select "customised: customised robot with Webhook"
  4. in the next new panel named "robot detail", click "Add" button.
  5. in "Add Robot" panel, input a nickname for the robot and select a "message group" which the robot will join in. click "next".
  6. there will be a Webhook URL in the panel, looks like this: https://oapi.dingtalk.com/robot/send?access_token=xxxxxxxxx. copy this URL to the grafana Dingtalk setting page and then click "finish" bottom.

Dingtalk supports the following "message type": text, link and markdown. this plugin only supports sending "text" message.

@zhengheyi

This comment has been minimized.

Show comment
Hide comment
@zhengheyi

zhengheyi commented Jul 10, 2017

@jiamliang Thank you.

@daniellee

This comment has been minimized.

Show comment
Hide comment
@daniellee
Member

daniellee commented Jul 10, 2017

@jiamliang thanks. Added those instructions to the docs: http://docs.grafana.org/alerting/notifications/#dingding-dingtalk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment