Add Kubernetes icon #86677
Add Kubernetes icon #86677
Conversation
sd2k
requested review from
joshhunt,
ashharrison90 and
mckn
and removed request for
a team
|
Would it be better to have this without the mask and only be a SVG? We will need the design asset to remain in parity with the code asset anyhow. If so, I can take the lead here and generate the SVG icon for this via Figma and attach it. |
|
I think it might be better that way if it still looks correct without the mask yeah - I had a quick go at it but haven't really worked with SVGs before so didn't know what I was doing. Would really appreciate it if you could take a look @staton-hyse11! |
|
@sd2k I've tagged you in a Figma file for the SVGs. Leave your thoughts there and I'll follow up with the final assets in this PR. |
|
Is this already solved? |
|
I've updated the icon to the one provided in Slack. Storybook screenshot:
|
|
Really like that one @sd2k , k8s app team approves 👍 |
This commit adds a new icon for Kubernetes. I've just taken the SVG from the Grafana K8S plugin and plopped it in the unicons directory following the 'How to add a new icon' instructions (removing width/height etc), but I'm unsure whether we should modify the SVG to instead have a single-colour version. I did have a quick go at this but it doesn't look quite right due to the lack of surrounding pentagon; perhaps everything needs inverting? I couldn't figure out how to do that though - happy to have another go if you think that'd look better (see attached screenshot).
See [this Slack message][msg] for details. [msg]: https://raintank-corp.slack.com/archives/C025WTVRBSN/p1713973825846459?thread_ts=1713969070.723679&cid=C025WTVRBSN
sd2k
force-pushed
the
add-kubernetes-icon
branch
from
f5f0806
to
bd54034
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
Clarity-89
added
the
no-changelog
* main: (25 commits) Update dependency @react-types/overlays to v3.8.7 LogsTable: Fix default sort by time (#88398) Update dependency @react-types/menu to v3.9.9 datatrails: in Components, `model.useState()`, instead of `model.state` (#88432) Update dependency @react-types/button to v3.9.4 Alerting docs: adds template selector docs (#88412) Update dependency @playwright/test to v1.44.1 Update dependency @kusto/monaco-kusto to v10.0.22 Update dependency @grafana/faro-web-sdk to v1.7.3 Alerting: Support `alertingDisableSendAlertsExternal` feature toggle (#88384) Update dependency @grafana/faro-web-sdk to v1.7.3 Add navigation config for `grafana-csp-app` (#88360) Chore: create the `no-untranslated-literals` rule (#88271) Alerting: Update ListAlertRulesQuery to take a slice of RuleGroups (#88385) Update dependency @grafana/faro-core to v1.7.3 Revamp tests for Add/Update Datasource (#88386) Update dependency @floating-ui/react to v0.26.16 (#88409) Update dependency cypress to v13.10.0 (#84140) Add Kubernetes icon (#86677) Update `make docs` procedure (#88404) ...
What is this feature?
This commit adds a new icon for Kubernetes. I've just taken the SVG from the Grafana K8S plugin and plopped it in the
uniconsdirectory following the How to add a new icon instructions (removing width/height etc), but I'm unsure whether we should modify the SVG to instead have a single-colour version. I did have a quick go at this but it doesn't look quite right due to the lack of surrounding shape; perhaps everything needs inverting? I couldn't figure out how to do that though - happy to have another go if you think that'd look better.In the below Storybook screenshot, the first (
kubernetes) is the version I've included in this PR, while the second (kubernetes2) is the result of using the second path as a mask and removing the fill attributes.Why do we need this feature?
Despite Grafana being used for lots of infra monitoring we don't have a Kubernetes icon. We do have a Docker one, so this feels like a natural extension.
Who is this feature for?
Plugin developers who want to be able to include a Kubernetes icon when using the
Iconcomponent from@grafana/ui.Which issue(s) does this PR fix?:
N/A
Special notes for your reviewer:
I asked about this in Slack a few months ago but never got round to it until now!
Please check that: