New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use B/s instead Bps for Bytes per second #9342

Merged
merged 3 commits into from Mar 8, 2018

Conversation

Projects
None yet
5 participants
@mayli
Contributor

mayli commented Sep 24, 2017

Most places are using bps and B/s for bits and bytes,
ref: https://en.wikipedia.org/wiki/Data_rate_units
Bps (Bytes per second) isn't a really common used unit the in the wild.

Use B/s instead Bps for Bytes per second
Most places are using bps and B/s for bits and bytes,
ref: https://en.wikipedia.org/wiki/Data_rate_units
Bps (Bytes per second) isn't a really common used unit the in the wild.
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Sep 24, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Sep 24, 2017

CLA assistant check
All committers have signed the CLA.

@mayli

This comment has been minimized.

Show comment
Hide comment
@mayli

mayli Sep 24, 2017

Contributor

I guess the current unit test doesn't support special characters in unit name.

Contributor

mayli commented Sep 24, 2017

I guess the current unit test doesn't support special characters in unit name.

@LucaDev

This comment has been minimized.

Show comment
Hide comment
@LucaDev

LucaDev Oct 3, 2017

I think the "XXX/s" format is a lot better than "bps" or something similar, but we should then change all units to match this (in my eyes) better format. On top of that: It would be mathematically correct. See: https://en.wikipedia.org/wiki/Units_of_measurement#Calculations_with_units_of_measurement

Edit: See #9401

LucaDev commented Oct 3, 2017

I think the "XXX/s" format is a lot better than "bps" or something similar, but we should then change all units to match this (in my eyes) better format. On top of that: It would be mathematically correct. See: https://en.wikipedia.org/wiki/Units_of_measurement#Calculations_with_units_of_measurement

Edit: See #9401

@torkelo

This comment has been minimized.

Show comment
Hide comment
@torkelo

torkelo Oct 4, 2017

Member

looks like this broke a unit test

Member

torkelo commented Oct 4, 2017

looks like this broke a unit test

@mayli

This comment has been minimized.

Show comment
Hide comment
@mayli

mayli Oct 4, 2017

Contributor

@torkelo fixed the unittest,

Contributor

mayli commented Oct 4, 2017

@torkelo fixed the unittest,

mayli added some commits Oct 4, 2017

@torkelo

Good, changing back the value to the previous one is correct as otherwise you would break thousands of dashboards that used it :)

@mayli

This comment has been minimized.

Show comment
Hide comment
@mayli

mayli Oct 10, 2017

Contributor

@torkelo any more changes i need to add to this patch?

Contributor

mayli commented Oct 10, 2017

@torkelo any more changes i need to add to this patch?

@bergquist bergquist added this to the 5.1 milestone Mar 8, 2018

@bergquist bergquist merged commit 675e5ae into grafana:master Mar 8, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@bergquist

This comment has been minimized.

Show comment
Hide comment
@bergquist

bergquist Mar 8, 2018

Contributor

Sorry for the slow response. This has been merged to master and will be available in 5.1

Closed by 64aedbf

Contributor

bergquist commented Mar 8, 2018

Sorry for the slow response. This has been merged to master and will be available in 5.1

Closed by 64aedbf

marefr added a commit that referenced this pull request Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment