[tempo-distributed] switch to new overrides format #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farodin91
requested review from
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
farodin91
changed the title
farodin91
force-pushed
the
tempo-distributed--switch-to-new-overrides-format
branch
3 times, most recently
from
17d6a4e
to
77f6e0e
Compare
|
@farodin91 @mapno @swartz-k @BitProcessor @faustodavid Can we get traction on this PR? You can't upgrade right now if you're using global overrides without some wonky workaround |
mapno
force-pushed
the
tempo-distributed--switch-to-new-overrides-format
branch
from
1ab05a6
to
a7e1b1f
Compare
|
If we can get another approval I'll merge 🙏 |
|
@swartz-k @BitProcessor @faustodavid can we get another approver for this one? |
|
Thanks for the contribution, @farodin91. Can you please update the branch and resolve the conflicts? |
3 tasks
YayBurritos
reviewed
Feb 28, 2024
charts/tempo-distributed/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: tempo-distributed | |||
| description: Grafana Tempo in MicroService mode | |||
| type: application | |||
| version: 1.8.2 | |||
| version: 1.8.3 | |||
There was a problem hiding this comment.
Looks like the latest tempo-distributed chart version is 1.8.4 (https://github.com/grafana/helm-charts/blob/main/charts/tempo-distributed/Chart.yaml), so I guess this one will become 1.8.5?
farodin91
force-pushed
the
tempo-distributed--switch-to-new-overrides-format
branch
from
a7e1b1f
to
57a3e38
Compare
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
farodin91
force-pushed
the
tempo-distributed--switch-to-new-overrides-format
branch
from
57a3e38
to
6162f55
Compare
faustodavid
approved these changes
Feb 29, 2024
farodin91
deleted the
tempo-distributed--switch-to-new-overrides-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.