[promtail] Tolerate node-role.kubernetes.io/control-plane:NoSchedule taints #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taints The Kubernetes project is moving away from offensive wording and as part of this KEP-2067 was accepted to replace the `node-role.kubernetes.io/master:NoSchedule` taint with `node-role.kubernetes.io/control-plane:NoSchedule`. To be compatible with clusters that already use the new taint this pull request adds an additional toleration for it. This change can't really break existing setups because we continue to tolerate the old taint as well. Additional links: - https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/2067-rename-master-label-taint/README.md - kubernetes/enhancements#2067 - kubernetes/kubeadm#2200 Signed-off-by: Max Rosin <git@hackrid.de>
|
Solved the merge conflict and ran helm-docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes project is moving away from offensive wording and as part
of this KEP-2067 was accepted to replace the
node-role.kubernetes.io/master:NoScheduletaint withnode-role.kubernetes.io/control-plane:NoSchedule.To be compatible with clusters that already use the new taint this pull
request adds an additional toleration for it. This change can't really
break existing setups because we continue to tolerate the old taint as
well.
Additional links:
Signed-off-by: Max Rosin git@hackrid.de