Skip to content

Conversation

@v-zhuravlev
Copy link
Contributor

Some JVM signals updates due to otel semantic convention update:

  1. Otel semconv v.1.22 version introduced breaking change in jvm runtime metrics. (just like windows-exporter)
  2. so
  3. New metrics are defined in observ-lib as described here in the latest spec https://opentelemetry.io/docs/specs/semconv/runtime/jvm-metrics/ in "otel_with_suffixes"
  4. previous otel metrics are moved to "otel_old" and "otel_old_with_suffixes"

P.S. _with_suffixes means with_suffixes is enabled as remote remotewrite option, which is default OTEL to prometheus translation suffixes in alloy and otel-collector.
More on this: https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#otlp-metric-points-to-prometheus

@v-zhuravlev v-zhuravlev requested a review from a team as a code owner October 11, 2025 19:42
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but generally looks good.

Aside from that the naming and amount of these signals is getting a bit much.

We should look at when and where we can clean them up, e.g. if we drop support fully for the prototype convention at some point. Thoughts?

@v-zhuravlev
Copy link
Contributor Author

We should look at when and where we can clean them up, e.g. if we drop support fully for the prototype convention at some point. Thoughts?

Yeah, some of them can be dropped later, as otel evolves.
What is the "prototype convention"? btw

@v-zhuravlev v-zhuravlev requested a review from Dasomeone October 23, 2025 18:12
@Dasomeone
Copy link
Member

We should look at when and where we can clean them up, e.g. if we drop support fully for the prototype convention at some point. Thoughts?

Yeah, some of them can be dropped later, as otel evolves. What is the "prototype convention"? btw

Apologies, not prototype! I just meant the old ones, e.g. otel_old and otel_old_with_suffixes, I had misread v1.21.0 as v0.21.0 so just called it a prototype when it's not 😅
Agreed it's definitely not something we need to do not, but something to look at next time we expand the list I think

@Dasomeone Dasomeone merged commit 9dbb57c into grafana:master Oct 24, 2025
11 checks passed
@v-zhuravlev v-zhuravlev deleted the jvm-otel branch October 24, 2025 15:55
postnati pushed a commit to postnati/jsonnet-libs that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants