Introduce a new flag to the k6 archive sub-command #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
changed the title
na--
reviewed
Aug 16, 2022
na--
reviewed
Aug 16, 2022
na--
reviewed
Aug 16, 2022
olegbespalov
force-pushed
the
feat/2587-env-excluding-archive
branch
2 times, most recently
from
a89d585
to
c97da13
Compare
olegbespalov
force-pushed
the
feat/2587-env-excluding-archive
branch
from
c97da13
to
88c69ce
Compare
na--
reviewed
Aug 17, 2022
olegbespalov
force-pushed
the
feat/2587-env-excluding-archive
branch
from
88c69ce
to
f5046b4
Compare
na--
previously approved these changes
Aug 17, 2022
mstoykov
previously approved these changes
Sep 7, 2022
codebien
previously approved these changes
Sep 7, 2022
olegbespalov
dismissed stale reviews from codebien, mstoykov, and na--
via
aef166d
olegbespalov
force-pushed
the
feat/2587-env-excluding-archive
branch
from
f5046b4
to
aef166d
Compare
codebien
requested changes
Sep 8, 2022
codebien
previously approved these changes
Sep 8, 2022
Introduced a new flag ` --exclude-env-vars`. If passed to the `k6 archive`, k6 doesn't embed any environment variables (either from --env or the actual environment) in the archive metadata.
olegbespalov
force-pushed
the
feat/2587-env-excluding-archive
branch
from
aef166d
to
7206f89
Compare
mstoykov
approved these changes
Sep 9, 2022
codebien
approved these changes
Sep 9, 2022
na--
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces a new flag to the
k6 archivecommand. If this flag is provided we exclude environment variables provided with the--envfrom the script's archive (metadata.json).Why?
There are some cases when environment variables are required for archiving, but it's safer to not store them.
Closes: #2587