From dfbaa0ada9e066d1a22faac5e3bf1bdec01a062c Mon Sep 17 00:00:00 2001 From: Mihail Stoykov Date: Fri, 8 Mar 2019 11:37:21 +0200 Subject: [PATCH 1/4] Add config for golangci currently most checks are enabled but we are only fixing error going forward and all current problems will stay and will be fixed as we refactor the code around them. --- .golangci.yml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .golangci.yml diff --git a/.golangci.yml b/.golangci.yml new file mode 100644 index 00000000000..9ef8322f11e --- /dev/null +++ b/.golangci.yml @@ -0,0 +1,30 @@ +run: + deadline: 5m + +issues: + # Maximum issues count per one linter. Set to 0 to disable. Default is 50. + max-issues-per-linter: 0 + # Maximum count of issues with the same text. Set to 0 to disable. Default is 3. + max-same-issues: 0 + + +linters-settings: + govet: + check-shadowing: true + goling: + min-confidence: 0 + gocyclo: + min-complexity: 25 + maligned: + suggest-new: true + dupl: + threshold: 100 + goconst: + min-len: 2 + min-occurrences: 2 + +linters: + enable-all: true + disable: + - gochecknoinits + fast: false From c21182ef87712360dce67eff3f9c3df8a628b977 Mon Sep 17 00:00:00 2001 From: Mihail Stoykov Date: Fri, 8 Mar 2019 12:48:00 +0200 Subject: [PATCH 2/4] typo in golangci --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 9ef8322f11e..c3b2754dec9 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -11,7 +11,7 @@ issues: linters-settings: govet: check-shadowing: true - goling: + golint: min-confidence: 0 gocyclo: min-complexity: 25 From dc880890b34111966c915591fe873c5987f988d2 Mon Sep 17 00:00:00 2001 From: Mihail Stoykov Date: Fri, 8 Mar 2019 13:36:24 +0200 Subject: [PATCH 3/4] skip generated files in golangci --- .golangci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index c3b2754dec9..1747ac19748 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,5 +1,9 @@ run: deadline: 5m + skip-files: + - ".*gen_elements.*\\.go$" + - ".*gen_test.*\\.go$" + - "rice-box.go$" issues: # Maximum issues count per one linter. Set to 0 to disable. Default is 50. From 7527200c583b10b4154dc19a6152607d7a54b894 Mon Sep 17 00:00:00 2001 From: Mihail Stoykov Date: Fri, 8 Mar 2019 14:38:19 +0200 Subject: [PATCH 4/4] Remove some of the nongenerated files added by dc880890 --- .golangci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 1747ac19748..9b0082f233f 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,8 +1,6 @@ run: deadline: 5m skip-files: - - ".*gen_elements.*\\.go$" - - ".*gen_test.*\\.go$" - "rice-box.go$" issues: