chore(engine): adjustments to log task short circuiting #20121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make some adjustments to short circuiting of log tasks: * Ensure that workers can properly subscribe to time change events, even if the root pipeline is wrapping an underlying pipeline. * Ignore cancelled tasks when enqueing, which otherwise failed the query when the workflow attempted to queue short-circuited tasks. * Permit propagating task status changes when the task state hasn't changed. * Serialize and deserialize ContributingTimeRange when using the protobuf codec. * Add an counter for the number of tasks cancelled due to short circuiting.
rfratto
force-pushed
the
engine-fix-short-circuiting-bugs
branch
from
2195c7c to
30a7a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some adjustments to short circuiting of log tasks:
Ensure that workers can properly subscribe to time change events, even if the root pipeline is wrapping an underlying pipeline.
Ignore cancelled tasks when enqueing, which otherwise failed the query when the workflow attempted to queue short-circuited tasks.
Permit propagating task status changes when the task state hasn't changed.
Serialize and deserialize ContributingTimeRange when using the protobuf codec.
Add an counter for the number of tasks cancelled due to short circuiting.