Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial to forward AWS ECS logs to Loki. #2331

Merged
merged 2 commits into from Jul 13, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #2331 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2331      +/-   ##
==========================================
+ Coverage   61.16%   61.39%   +0.23%     
==========================================
  Files         158      158              
  Lines       12799    12799              
==========================================
+ Hits         7828     7858      +30     
+ Misses       4374     4345      -29     
+ Partials      597      596       -1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.54% <0.00%> (+0.40%) ⬆️
pkg/promtail/targets/file/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.93% <0.00%> (+2.06%) ⬆️
pkg/promtail/targets/file/tailer.go 76.13% <0.00%> (+2.27%) ⬆️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️
pkg/logql/vector.go 87.50% <0.00%> (+18.75%) ⬆️

… case.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@owen-d owen-d merged commit 2cd3633 into grafana:master Jul 13, 2020
@vitaliy-madonov
Copy link

Config files in tutorial are missed (i.e. https://raw.githubusercontent.com/grafana/loki/master/docs/aws/ecs/ecs-task.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants