Refactor pkg/util/server to avoid cortexpb import in downstream projects vendoring logql #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts vendoring logql Signed-off-by: Marco Pracucci <marco@pracucci.com>
cyriltovena
approved these changes
Nov 26, 2021
|
Thanks @pracucci 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR #4814 introduced a cascading dependency from
pkg/logqltocortexpb(from Cortex project). This is causing a conflict in a downstream project (GEM). More details here:#4814 (comment)
In this PR I'm proposing an option to avoid the
cortexpbcascading dependency for projects importinglogql(I've tested this change and works from GEM perspective). Not sure if the refactoring I've done in the PR is acceptable for Loki project; if not, please share an alternative suggestion on how to solve. Thanks!Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.