-
Notifications
You must be signed in to change notification settings - Fork 173
Support username/password authentication #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can get it either via HTTP basic auth or environment variables
…cally Thought they passed, turns out nothing ran (I am new to go sorry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! The one thing I'd love to see is an end-to-end test. I think it should be possible to:
- set
GF_AUTH_ANONYMOUS_ENABLED: "false"in our docker-compose file - modify the code that creates a new test context to set the basic auth (
admin/admin) on the client used by integration tests - update the e2e.yml GitHub workflow to set the env vars for the
Start MCP server in backgroundstep
I know it's a bit annoying to run these e2e tests since they require OpenAI/Anthropic usage so I can add this in a separate PR if you like, just let me know.
(Also, the e2e tests are failing right now, they're a bit flaky depending on how the LLMs are feeling on the day, so don't worry about those failures)
|
Thanks for explaining! Will add it in this PR |
Luckily I did, turns out the alerting client uses a different auth system
Set the env globally so that - When it gets started as a process by the tests it is picked up - When it gets started as a background process it is picked up
|
I was able to get integration running locally, e2e just wasn't happy though (Got litellm to the local qwen model that I use but did not work well...) |
|
Nice, this looks and works great. Thank you @ire4ever1190! One request, could you update the |
Thanks! Completed in latest commit |
Implements #256
Supports connecting via basic auth if the instance supports it.
Configured via either
GRAFANA_USERNAMEGRAFANA_PASSWORDWorks locally when connecting to grafana instance that has basic auth
