fix: add Overrides to Flusher dependencies to prevent panic on startup #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rohankmr414
changed the title
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
osg-grafana
reviewed
Oct 7, 2022
|
The fix LGTM! Please address this to get it merged: |
Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
|
Do we know that this really fixes flusher? It would be nice to add integration test for flusher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohan Kumar rohankmr414@gmail.com
What this PR does
This PR adds
Overridesmodule as a dependencyFlusherto prevent panics on startup. Before removing chunks storage in #755, Flusher depended onStorewhich depended onOverridesmodule, this might be the reason behind panicsWhich issue(s) this PR fixes or relates to
Fixes #2866
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]