Refactoring: do not pass the chunks pool to newBucketChunkReader() #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
dimitarvdimitrov
approved these changes
Dec 1, 2022
| // save a copy of b's payload to a buffer pulled from chunksPool. | ||
| // The buffer containing the chunk data is returned. | ||
| // The returned slice becomes invalid once chunksPool is released. | ||
| func (r *bucketChunkReader) save(b []byte, chunksPool *pool.BatchBytes) ([]byte, error) { |
There was a problem hiding this comment.
This doesn't have to be a method of bucketChunkReader anymore
There was a problem hiding this comment.
And even better - what do you think about inlining it in populateChunk? It's simple enough and it's not used elsewhere
There was a problem hiding this comment.
Makes sense to me.
There was a problem hiding this comment.
I will also move populateChunk() to bucket_chunk_reader.go.
There was a problem hiding this comment.
While doing it, I realized that inlining save() logic into populateChunk() makes the code harder to read. I will keep other suggestions tho.
There was a problem hiding this comment.
yeah I'm happy with what you have. also removing the indirection of passing a func is good enough
…nk() to bucket_chunk_reader.go Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
added a commit
that referenced
this pull request
Dec 1, 2022
…3611) * Refactoring: do not pass the chunks pool to newBucketChunkReader() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Renamed bucketChunkReader.save() to saveChunk() and moved populateChunk() to bucket_chunk_reader.go Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…rafana#3611) * Refactoring: do not pass the chunks pool to newBucketChunkReader() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Renamed bucketChunkReader.save() to saveChunk() and moved populateChunk() to bucket_chunk_reader.go Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently
newBucketChunkReader()requires the chunks pool in input. This complicates the implementation of the streaming store-gateway, so in this PR I'm proposing to remove it and just pass the chunks pool tobucketChunkReader.load()which is where is required. Keep in mindpool.BatchBytesis concurrency safe.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]