Distributor: Return 529 for ingestion rate limit when serviceOverloadErrorEnabled #6549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-jeanne
changed the title
ying-jeanne
changed the title
ying-jeanne
changed the title
pstibrany
reviewed
Nov 3, 2023
This is experimental feature, even we don't use it anywhere internally yet. |
ying-jeanne
force-pushed
the
retry-on-rate-limit
branch
from
f62786f
to
e281d92
Compare
ying-jeanne
force-pushed
the
retry-on-rate-limit
branch
from
5d508bb
to
5ba247e
Compare
ying-jeanne
force-pushed
the
retry-on-rate-limit
branch
from
5ba247e
to
ed3c3a9
Compare
|
@aknuds1 @pstibrany It is important to give it whatever its deserved. PR updated, could you give it another look. thanks |
ying-jeanne
force-pushed
the
retry-on-rate-limit
branch
from
dd50585
to
292c925
Compare
pstibrany
approved these changes
Nov 14, 2023
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been overlooked. The flag was introduced in this PR. We also need to implement a similar approach for the ingestion rate limit to prevent data loss when rate limiting occurs.
Comment is equally added into doc, since with load test, I have observed that returning 529 instead of 429 could result in enhancing thundering herd. See test result
Metrics data accumulates for 5 minutes with 1000 agents, after which the network is enabled to transmit data to Mimir. This results in a 429 error code, impacting the request rate on the gateway:
with 529 error code, request rate on gateway:
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]