introduce LOG_TAGs, avoid repetitive prefixes #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ordian
reviewed
Feb 11, 2022
Contributor
|
@drahnr It's not documented but there are three main components in this library: Agent, Timer and Session. Each one has its own thread. I think a better approach is to have a local Tag for every part instead of a global one. |
drahnr
force-pushed
the
main
branch
2 times, most recently
from
d9e7ca3 to
608c5e2
Compare
drahnr
changed the title
new
Contributor
Author
|
Rebased and reduced |
Contributor
|
@drahnr Can you check my comment regarding the unwrap"s" for the drop function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.