fix: SelectSeries not correct for single reports #4617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
SelectSeriesqueries return incorrectly formatted time series data when only a single report is processed. The query backend was skipping the aggregation step for single reports, but for time series queries, the aggregation function is critical for ensuring proper ordering and correctness of the data structure.Problem
The query backend only calls aggregate functions when there is more than one report for a particular type. For time series queries, this caused issues because the aggregate function also ensures the order and correctness of the data shape, not just combining multiple reports.
Solution
alwaysAggregateflag to the query type registration systemChanges
registerQueryType()to accept analwaysAggregateparameter (pkg/querybackend/query.go:70)report_aggregator.goto track and check which report types require aggregation for single reportsalwaysAggregate: truefor time series queries (pkg/querybackend/query_time_series.go:25)Test_QueryTimeSeriesOneReport()validates single report behavior (pkg/querybackend/block_reader_test.go:274)alwaysAggregate: falseTest Plan
🤖 Generated with Claude Code