Skip to content

Address zizmor scan results#218

Merged
andyasp merged 3 commits into
mainfrom
aasp/zizmor-scan-results
Apr 30, 2025
Merged

Address zizmor scan results#218
andyasp merged 3 commits into
mainfrom
aasp/zizmor-scan-results

Conversation

@andyasp

@andyasp andyasp commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

There were only warnings

@alexweav alexweav left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please check my question

# Allow manually triggering
workflow_dispatch:

permissions: {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does a Checkout Code step later on - does it need contents: read? 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permissions are on the job in line 14.

@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@andyasp andyasp merged commit 0db73a2 into main Apr 30, 2025
@andyasp andyasp deleted the aasp/zizmor-scan-results branch April 30, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants