SceneQueryRunner: Only use containerWidth when maxDataPointsFromWidth is true #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
approved these changes
Jun 1, 2023
torkelo
added
minor
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug on https://ops.grafana-ops.net/a/grafana-app-observability-app/services/datadog-proxy-gateway/overview?var-prometheus=ops-cortex&var-loki=Loki-Ops&var-tempo=Tempo%20%28tempo-ops%29&from=now-6h&to=now
where it issues the first request with the default 500 data points, second request it issues using containerWidth.
containerWidth should only be used for maxDataPoints if maxDataPointsFromWidth is true.
Not sure what the default behavior should be here. because SceneQueryRunner can be placed anywhere in the tree and it's only when it's on VizPanel and when there is a timeseries graph visualization that using containerWidth for maxDataPoints is actually good I figured it best to make it opt in.