PanelContext: Eventbus should not filter out local events #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah, the first demo scene has global scope, got confused when panel titles said |
dprokop
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Works good against core dashboards as well. Think we can land this, and work on grafana/grafana#71866 some time in the next few week.s
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pie chart legend hover events are not working. They highlight slices on the same panel and using the standard DataHoverEvent. The panel relies on being able to subscribe to local events. But the scenes PanelContextEventBus filters out any local events.
Removing this filtering, panels filter out local events they don't care about using:
Trying to make the needed changes to get that to work. But when testing the cursor sync demo I am unable to get it to work (with or without these changes). All cursors show on all panels. Think uPlot cursor sync scope key has broken.
We could also try to revive grafana/grafana#71866