Possibility to refresh variable options based on state changes #827
Conversation
mdvictor
added
patch
| private _handleVariableOptionsUpdate(variable: SceneVariable) { | ||
| this._variablesToUpdate.add(variable); | ||
|
|
||
| this._updateNextBatch(); | ||
| } |
There was a problem hiding this comment.
don't think this is needed, The variable can handle this and if the value changes due to options changes then it should emit the event for variable value change
There was a problem hiding this comment.
but if the current variable value is a single value then updating options does not change anything (no need to update other variables).
There was a problem hiding this comment.
I think we need it because the values aren't changing, only the options or options related properties. For example if the options sorting changes we need to update that var and show the options asc/desc in the UI, but the value itself does not change.
I don't understand how variable value change would help here, I might be missing some piece of the puzzle.
There was a problem hiding this comment.
@mdvictor I just don't understand why the set needs to handle this, this concern of updating options based on sorting etc is fully the responsibility of the variable.
the set is only concerned if the value changes and if that should trigger cascading updates to other variables, and for that we have the SceneVariableValueChangedEvent event
There was a problem hiding this comment.
ah, I understand what you mean now, yeah that makes sense, I'll move this for the variable itself to handle.
There was a problem hiding this comment.
@torkelo I modified this to be handled by the variable itself, definitely better
|
🚀 PR was released in |
Add possibility to manually trigger a variable options refresh after a state change. Needed for various variable components in react scenes. E.g.: #818
📦 Published PR as canary version:
5.7.5--canary.827.10385100405.0✨ Test out this PR locally via:
npm install @grafana/scenes-react@5.7.5--canary.827.10385100405.0 npm install @grafana/scenes@5.7.5--canary.827.10385100405.0 # or yarn add @grafana/scenes-react@5.7.5--canary.827.10385100405.0 yarn add @grafana/scenes@5.7.5--canary.827.10385100405.0