Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tk init should also download the k8s libsonnet #52

Open
gouthamve opened this issue Aug 16, 2019 · 2 comments

Comments

@gouthamve
Copy link
Member

commented Aug 16, 2019

Tanka is kubernetes focused but it's surprising that we need to download the k8s.libsonnet anyways using bundler. I would expect that tk init already contains the jsonnet required.

@issue-label-bot

This comment has been minimized.

Copy link

commented Aug 16, 2019

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.62. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@sh0rez

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

This is somewhat opinionated about what libraries somebody should use.

So far Tanka is a rather open and general system which avoids assumptions and does not really impose anything (aside of using jsonnet).

Furthermore, there are multiple versions of this library (for different Kubernetes versions), while at tk init time, we do not know what cluster is going to be used.

I would rather maintain both separately and suggest the use with each-other, but not force people to. Happy to discuss.
/cc @tomwilkie @malcolmholmes

@gouthamve what about printing the jb install commands for those once tk init is done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.