Delete gracefully if user no longer exist in grafana#991
Merged
julienduchesne merged 1 commit intografana:masterfrom Aug 1, 2023
Merged
Conversation
|
|
Contributor
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
pascal-hofmann
force-pushed
the
fail-gracefully-if-user-already-deleted
branch
2 times, most recently
from
f37d858 to
b8ea3e0
Compare
pascal-hofmann
changed the title
When applying a terraform plan that was created with `-refresh=false` the
detection of resources that no longer exist in grafana does not work,
as the resources are not read at all.
Thus on apply, a deletion of a user that no longer exists in grafana fails with:
```
Error: status: 404, body: {"message":"user not found"}
```
This change modifies `DeleteUser` so that it catches this case and does
not return an error.
julienduchesne
force-pushed
the
fail-gracefully-if-user-already-deleted
branch
from
b8ea3e0 to
ea58a03
Compare
julienduchesne
approved these changes
Aug 1, 2023
Contributor
Author
|
Thank you for the quick review and merge! 🚀👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a terraform plan that was created with
-refresh=falsethe detection of resources that no longer exist in grafana does not work, as the resources are not read at all.Thus on apply, a deletion of a user that no longer exists in grafana fails with:
This change modifies
DeleteUserso that it catches this case and does not return an error.