New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latitude and longitude if given in table data #144

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
5 participants
@kylios
Copy link
Contributor

kylios commented Jun 10, 2018

I've seen a couple issues open for this, and in one of them, you mentioned you'd accept a pull request for this feature. I took a stab at it, and got it working in a local grafana instance that's connected to an influxdb data source with some location data in the form of lat and lon. There was no good place in my pipeline to convert these points to geohash before inserting them into my database, and I figured it would just be nice if this plugin supported rendering latitude and longitude points as well as geohash points.

When reading and formatting table data only, it will look for latitude and longitude specified in the datapoint and use those. If a geohash is provided, then that will override any given latitude and longitude. There is a unit test to show this working.

2018-06-10-144945_1122x1120_escrotum

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jun 10, 2018

CLA assistant check
All committers have signed the CLA.

@daniellee daniellee self-assigned this Jun 21, 2018

@daniellee daniellee merged commit 81fea16 into grafana:master Jun 21, 2018

1 check passed

license/cla Contributor License Agreement is signed.
Details
@daniellee

This comment has been minimized.

Copy link
Member

daniellee commented Jun 21, 2018

This looks like a very useful feature - should work well with the sql datasources as well. Thank you!

@jacoscaz

This comment has been minimized.

Copy link

jacoscaz commented Jun 23, 2018

This is fantastic!

@OliPassey

This comment has been minimized.

Copy link

OliPassey commented Aug 1, 2018

Is this in general release now? Is there any documentation?
Struggling to get it showing any markings on the map.

Sending data: GPSTracking,subject=Oli,latitude=51.******,longitude=-0.******,country=UK value=10

Which is accepted into InfluxDB ok, but no markers - any ideas / info would be much appreciated.

Edit: Got it working, huge thanks for adding this code @kylios
Using with GPSLogger.app Msg Body should be: GPSTracking,Country=UK,Subject=Oli latitude=%LAT,longitude=%LON for anyone interested.

@OliPassey OliPassey referenced this pull request Aug 1, 2018

Closed

Log to InfluxDB? #665

@daniellee

This comment has been minimized.

Copy link
Member

daniellee commented Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment