Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Better unicode handling in --notes " éà^e" #18

Merged
merged 2 commits into from Aug 28, 2013

Conversation

Projects
None yet
2 participants
Contributor

yml commented Mar 11, 2013

Everytime I use unicode char in --notes kip is raising an error out.
I don't think we need the unicode encoding/decoding dance in python 3

Here it is a command that is causing issue :

kip add yml_test --username 'yml' --notes "éàu"

grahamking added a commit that referenced this pull request Aug 28, 2013

Merge pull request #18 from yml/master
Better unicode handling in --notes " éà^e"

@grahamking grahamking merged commit f9aedb2 into grahamking:master Aug 28, 2013

Owner

grahamking commented Aug 28, 2013

Sorry Yann, I completely forgot about this!

I had to revert 8792776 as I was getting "TypeError: 'str' does not support the buffer interface" in cli.py line 301.

Are you sure you're on python3? You need to install it like "sudo python3 setup.py install". I can replicate the error on python2 but not 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment