Browse files

added warning about actionSubmit

  • Loading branch information...
Burt Beckwith
Burt Beckwith committed Jan 31, 2012
1 parent 72c1ff2 commit 3bc45f7c56e5b55694d198115e681b97bf1a04db
Showing with 19 additions and 0 deletions.
  1. +19 −0 src/docs/guide/5 Configuring Request Mappings to Secure URLs.gdoc
@@ -30,6 +30,25 @@ With @IS_AUTHENTICATED_FULLY@ you can implement a security scheme whereby users
For more information on @IS_AUTHENTICATED_FULLY@, @IS_AUTHENTICATED_REMEMBERED@, and @IS_AUTHENTICATED_ANONYMOUSLY@, see the Javadoc for [AuthenticatedVoter|]
+The plugin isn't compatible with Grails @<g:actionSubmit>@ tags. These are used in the autogenerated GSPs that are created for you, and they enable having multiple submit buttons, each with its own action, inside a single form. The problem from the security perspective is that the form posts to the default action of the controller, and Grails figures out the handler action to use based on the @action@ attribute of the @actionSubmit@ tag. So for example you can guard the @/person/delete@ with a restrictive role, but given this typical edit form:
+ ...
+ <g:actionSubmit class="save" action="update"
+ value='Update' />
+ <g:actionSubmit class="delete" action="delete"
+ value="'Delete' />
+both actions will be allowed if the user has permission to access the @/person/index@ url, which would often be the case.
+The workaround is to create separate forms without using @actionSubmit@ and explicitly set the @action@ on the @<g:form>@ tags, which will result in form submissions to the expected urls and properly guarded urls.
h4. Comparing the Approaches
Each approach has its advantages and disadvantages. Annotations and the @Config.groovy@ Map are less flexible because they are configured once in the code and you can update them only by restarting the application (in prod mode anyway). In practice this limitation is minor, because security mappings for most applications are unlikely to change at runtime.

0 comments on commit 3bc45f7

Please sign in to comment.